Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: use same version of setuptools when using system_packages #10287

Merged
merged 2 commits into from
May 3, 2023
Merged

Build: use same version of setuptools when using system_packages #10287

merged 2 commits into from
May 3, 2023

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 3, 2023

The same version installed before needs to match here, otherwise for some reason pip gives you an error when installing some packages.

Fixes #10285

@stsewd
Build: use same version of setuptools when using system_pacakges
9242996 
The same version installed before needs to match here.

Fixes #10285
@stsewd stsewd requested a review from a team as a code owner May 3, 2023 15:45
@stsewd stsewd requested a review from benjaoming May 3, 2023 15:45
@stsewd stsewd mentioned this pull request May 3, 2023
Closed
@stsewd
Copy link
Member Author

stsewd commented May 3, 2023

Tested this locally, and it fixes the problem

benjaoming
benjaoming approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the right thing to do.

I'm guessing most projects don't have use_system_site_packages enabled. And those that do are likely now starting to see failures because version 58 is old (sept '21).

Did you try running builds for any of the projects mentioned in #8775 ?

@jdkent jdkent mentioned this pull request May 3, 2023
Merged
@stsewd stsewd changed the title Build: use same version of setuptools when using system_pacakges Build: use same version of setuptools when using system_packages May 3, 2023
@stsewd
Copy link
Member Author

stsewd commented May 3, 2023

Did you try running builds for any of the projects mentioned in #8775 ?

Just did, all good

@stsewd stsewd merged commit 51d03d6 into main May 3, 2023
@stsewd stsewd deleted the use-same-version-of-setuptools branch May 3, 2023 17:49
@namurphy namurphy mentioned this pull request May 3, 2023
Merged
@mlxd mlxd mentioned this pull request May 5, 2023
Merged
@vincentmr vincentmr mentioned this pull request May 5, 2023
Merged
5 tasks
@multiphaseCFD multiphaseCFD mentioned this pull request May 5, 2023
Merged
5 tasks
@Vital-Fernandez
Copy link

Tested this locally, and it fixes the problem

Sorry, could you share how you fixed it, please? I am having the same issue in my library .

I only have this issue on the platform, it compiles fine on my computer.

@benjaoming
Copy link
Contributor

benjaoming commented May 8, 2023 •
edited
Loading

@Vital-Fernandez this change isn't released yet. Keep an eye out for the next release here: https://github.com/readthedocs/readthedocs.org/tags or here: https://docs.readthedocs.io/en/stable/changelog.html

@Vital-Fernandez
Copy link

@Vital-Fernandez this change isn't released yet. Keep an eye out for the next release here: https://github.com/readthedocs/readthedocs.org/tags or here: https://docs.readthedocs.io/en/stable/changelog.html

Thank you, I shall wait for the new version (I am glad to know it was not something I did, this time :)

@kanekosh kanekosh mentioned this pull request May 8, 2023
Merged
13 tasks
stsewd added a commit that referenced this pull request May 9, 2023
@stsewd
Build: use same version of setuptools when using system_packages (#…
9a7bf3a 
…10287)

The same version installed before needs to match here.

Fixes #10285
stsewd added a commit that referenced this pull request May 9, 2023
@stsewd
Build: use same version of setuptools when using system_packages (#…
d4ce77c 
…10287)

The same version installed before needs to match here.

Fixes #10285
@stsewd
Copy link
Member Author

stsewd commented May 9, 2023

@Vital-Fernandez this fix has been released. I just triggered a build for your project, but looks like it's failing for another reason https://readthedocs.org/projects/lime-stable/builds/20575086/.

@Vital-Fernandez
Copy link

@Vital-Fernandez this fix has been released. I just triggered a build for your project, but looks like it's failing for another reason https://readthedocs.org/projects/lime-stable/builds/20575086/.

Thank you very much!!!! It works great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaoming benjaoming benjaoming approved these changes

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not execute setup.py since setuptools is not available in the build environment
3 participants
@stsewd @Vital-Fernandez @benjaoming